RFR: 8345052: Harden StampedLock [v2]

[Alan Bateman]

On Thu, 28 Nov 2024 12:25:28 GMT, Doug Lea <dl at openjdk.org> wrote:

>> This applies the same kinds of recovery on OOME (by spinning) and JVM Exceptions (by cancelling) seen in AQS.
>
> Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8345052
>  - Add fall-back on OOME, cancel on JVM exceptions

Marked as reviewed by alanb (Reviewer).

Viktor is repeat testing the test as OOME tests have historically been problematic to be stable in all configs.

The changes to StampedLock looks okay to me. A minor comment on naming is that it feels like spinLockOnOOME is really acquireOnOOME or spinAcquireOnOOME but it's all internal and doesn't matter.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22396#pullrequestreview-2468472552
PR Comment: https://git.openjdk.org/jdk/pull/22396#issuecomment-2506389081