RFR: 8344299: SM cleanup in javax.naming modules [v2]

[Alan Bateman]

On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and `AccessController` usages from `java.naming`, `jdk.naming.rmi` and `jdk.naming.dns` modules.
>> 
>> One noteworthy change: The `java.naming.rmi.security.manager` JNDI environment property can be used to setup the `SecurityManager`: if the property is added to an environment map the `RegistryContext` attempts to setup the `SecurityManager`. The environment property and related method are removed in this PR. 
>> 
>> `tier1` - `tier3`, and other non-tiered JNDI tests showed no failures related to this change.
>
> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove com.sun.jndi.ldap.VersionHelper

I did a pass over the updated changes and don't see any issues, good cleanup.

src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java line 70:

> 68:                 null,
> 69:                 new RuntimePermission("ldapDnsProvider"),
> 70:                 SecurityConstants.GET_CLASSLOADER_PERMISSION);

Can you check if SecurityConstants.GET_CLASSLOADER_PERMISSION be removed now, I think this is the last usage.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22421#pullrequestreview-2468560741
PR Review Comment: https://git.openjdk.org/jdk/pull/22421#discussion_r1862468268