Integrated: 8345075: java.lang.module.ModuleDescriptor constructor could be made private

Eirik Bjørsnøs eirbjo at openjdk.org
Thu Nov 28 17:40:41 UTC 2024


On Tue, 26 Nov 2024 20:48:24 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please consider this cleanup PR which makes the now package-protected `ModuleDescriptor` constructor private.
> 
> This constructor is only accessed by the class itself via JavaLangModuleAccess. Making it private would express the intent of this class as being non-subclassable.
> 
> Marking this class final is handled separately in JDK-8344943 via a CSR.

This pull request has now been integrated.

Changeset: 43000a34
Author:    Eirik Bjørsnøs <eirbjo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/43000a34d5ba6e2e997893a90dac0fe6693611cb
Stats:     13 lines in 1 file changed: 0 ins; 0 del; 13 mod

8345075: java.lang.module.ModuleDescriptor constructor could be made private

Reviewed-by: alanb

-------------

PR: https://git.openjdk.org/jdk/pull/22399


More information about the core-libs-dev mailing list