RFR: 8345120: A likely bug in StringSupport::chunkedStrlenShort [v3]

Per Minborg pminborg at openjdk.org
Fri Nov 29 09:49:42 UTC 2024


On Fri, 29 Nov 2024 09:01:35 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix imports
>
> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java line 400:
> 
>> 398:      */
>> 399:     @ForceInline
>> 400:     public static int strlenByte(final AbstractMemorySegmentImpl segment,
> 
> Can we put these back in `StringSupport`? It makes it hard to review the differences side-by-side. (We can maybe decide later whether to move). In general if we keep the `StringSupport` class it's a bit weird to have the `strlen` methods not be there -- but I agree there's a similarity between this and other bulk operations.

I've moved back the methods to `StringSupport`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22451#discussion_r1863249968


More information about the core-libs-dev mailing list