RFR: 8343780: Add since checker tests to the Tools area modules and add missing @since to jdk.jfr.Recording [v2]

Nizar Benalla nbenalla at openjdk.org
Fri Nov 29 11:11:39 UTC 2024


On Fri, 29 Nov 2024 11:00:15 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add backticks, as they are necessary. Otherwise the `@since` is treated as a jtreg tag
>>   
>>   Revert "remove backticks"
>>   
>>   This reverts commit 83afb011685a4bc09bc994dd9a8891f6cdfe7217.
>
> test/jdk/tools/sincechecker/modules/jdk.jlink/JdkJlinkCheckSince.java line 29:
> 
>> 27:  * @summary Test for `@since` in jdk.jlink module
>> 28:  * @library /test/lib /test/jdk/tools/sincechecker
>> 29:  * @run main SinceChecker jdk.jlink
> 
> Missing "last" line? 
> Suggestion:
> 
>  * @run main SinceChecker jdk.jlink
>  */

You're right. Will update, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21982#discussion_r1863360287


More information about the core-libs-dev mailing list