RFR: 8341135: Incorrect format string after JDK-8339475

[Aleksey Shipilev]

On Tue, 1 Oct 2024 07:22:46 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> This fixes a format string issue.
> 
> In the error report it was reported : 'The compiler should be able to catch this if JLI_ReportErrorMessageSys was declared with something like __attribute__ ((format (printf, 1, 2))).'
> Should we maybe adjust  JLI_ReportErrorMessageSys , JLI_ReportErrorMessage  and related functions/methods  using a format string so that such errors can be found already at build time ?

Marked as reviewed by shade (Reviewer).

src/java.base/macosx/native/libjli/java_md_macosx.m line 315:

> 313:     rc = pthread_create(&main_thr, NULL, &apple_main, &args);
> 314:     if (rc != 0) {
> 315:         JLI_ReportErrorMessageSys("Could not create main thread, return code:%d\n", rc);

Shouldn't there be a space in between, `return code: %d`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/21278#pullrequestreview-2340041653
PR Review Comment: https://git.openjdk.org/jdk/pull/21278#discussion_r1782670820