RFR: 8341135: Incorrect format string after JDK-8339475

Christoph Langer clanger at openjdk.org
Tue Oct 1 13:01:35 UTC 2024


On Tue, 1 Oct 2024 12:40:57 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> src/java.base/macosx/native/libjli/java_md_macosx.m line 315:
>> 
>>> 313:     rc = pthread_create(&main_thr, NULL, &apple_main, &args);
>>> 314:     if (rc != 0) {
>>> 315:         JLI_ReportErrorMessageSys("Could not create main thread, return code:%d\n", rc);
>> 
>> Shouldn't there be a space in between, `return code: %d`?
>
> I can live with both, not sure what is preferred.  In the corresponding fprintf output of 8339475 there is no space.

I think a space would be nicer. 😄

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21278#discussion_r1782726535


More information about the core-libs-dev mailing list