RFR: 8340229: Improve opening sentence of FileInputStream constructor specification

Alan Bateman alanb at openjdk.org
Tue Oct 1 15:49:40 UTC 2024


On Mon, 30 Sep 2024 23:13:54 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/FileInputStream.java line 118:
>> 
>>> 116:     /**
>>> 117:      * Creates a {@code FileInputStream} to read from an existing file
>>> 118:      * named by the {@code File} object {@code file}.
>> 
>> Hello Brian, should be perhaps reword this as "... to read from an existing file represented by the {@code file}." This would almost match what we state for the constructor which takes the `FileDescriptor` instance.
>
> Updated for the next commit.

Did you push that commit? I don't see the update, the PR only has 1 commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21223#discussion_r1783108409


More information about the core-libs-dev mailing list