RFR: 8339538: Wrong timeout computations in DnsClient [v8]
Aleksei Efimov
aefimov at openjdk.org
Wed Oct 2 13:38:18 UTC 2024
On Mon, 30 Sep 2024 13:38:48 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Track unfulfilled timeouts during UDP queries.
>> Update exceptions handling.
>> Update TCP client to use nano time source.
>
> src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java line 247:
>
>> 245: continue;
>> 246: }
>> 247: AtomicLong unfulfilledServerTimeout = unfulfilledUdpTimeouts[i];
>
> Suggestion:
>
> // unfulfilledServerTimeout is always >= 0
> AtomicLong unfulfilledServerTimeout = unfulfilledUdpTimeouts[i];
Thanks for the suggestion. Added in [793cfda](https://github.com/openjdk/jdk/pull/20892/commits/793cfda3282788d5af5efa57db6eeb58641eb3ed)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1784539513
More information about the core-libs-dev
mailing list