RFR: 8341402: BigDecimal's square root optimization [v2]
Raffaello Giulietti
rgiulietti at openjdk.org
Thu Oct 3 09:21:37 UTC 2024
On Thu, 3 Oct 2024 09:10:07 GMT, fabioromano1 <duke at openjdk.org> wrote:
>> @rgiulietti I tried to implement and test stripping zeros algorithm with repeated squares trick, and on my laptop it takes around two seconds for strip one million of zeros. So, I decided to remove the method `stripZerosToEvenScale()`, in order to use only the `stripZerosToMatchScale()` logic.
>
> @fabioromano1 I agree with starting a new PR for speed up `stripZerosToMatchScale()`.
I'll open a JBS issue to refer to as soon as you open the new PR.
Please keep the first PR comment as short as possible, then add further details in another comment. As only the first comment is auto-copied in every email in the mailing list, keeping it short helps with bandwidth.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21301#discussion_r1785902622
More information about the core-libs-dev
mailing list