RFR: 8329597: C2: Intrinsify Reference.clear [v6]
Aleksey Shipilev
shade at openjdk.org
Thu Oct 3 16:57:40 UTC 2024
On Wed, 2 Oct 2024 10:47:09 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Also dispatch to slow-path on other arches
>
> test/micro/org/openjdk/bench/java/lang/ref/ReferenceClear.java line 2:
>
>> 1: //
>> 2: // * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Drive-by comment: The `// *` format looks weird.
Actually, this constellation of single-line comments should be replaced with a multi-line comment block. The fix is now in my (unpublished) patch queue, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20139#discussion_r1786548233
More information about the core-libs-dev
mailing list