RFR: 8339205: Optimize StackMapGenerator [v2]

[ExE Boss]

On Fri, 4 Oct 2024 14:03:20 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Reduce code size by combining calls and defining local variables
>
> Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
> 
>  - reduce codeSize
>  - reduce codeSize
>  - decStack & stackUnderflow
>  - fix merge error
>  - Merge branch 'master' into optim_stack_map_gen_202408
>  - Merge remote-tracking branch 'upstream/master' into optim_stack_map_gen_202408
>    
>    # Conflicts:
>    #	src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>  - Merge remote-tracking branch 'upstream/master' into optim_stack_map_gen_202408
>    
>    # Conflicts:
>    #	src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>  - fix merge error
>  - Merge remote-tracking branch 'origin/optim_stack_map_gen_202408' into optim_stack_map_gen_202408
>  - optimize for codeSize
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/3f420fac...b647a4b5

Typo (`Lcals` → `Locals`):

src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java line 1090:

> 1088:             if (index >= frameMaxLocals) frameMaxLocals = index + 1;
> 1089:             if (locals == null) {
> 1090:                 initLcals(index);

Suggestion:

                initLocals(index);

src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java line 1097:

> 1095:         }
> 1096: 
> 1097:         private void initLcals(int index) {

Suggestion:

        private void initLocals(int index) {

-------------

PR Review: https://git.openjdk.org/jdk/pull/20756#pullrequestreview-2274345739
PR Review Comment: https://git.openjdk.org/jdk/pull/20756#discussion_r1740079730
PR Review Comment: https://git.openjdk.org/jdk/pull/20756#discussion_r1740079772