RFR: 8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode} [v5]

Chen Liang liach at openjdk.org
Mon Oct 7 04:38:45 UTC 2024


On Wed, 7 Aug 2024 00:02:46 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> First pass at adding some quality of implementation discussions around the overridable methods of Object.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Fix typo found in code review.
>  - Merge branch 'master' into JDK-8336043
>  - Merge branch 'master' into JDK-8336043
>  - Respond to review feedback.
>  - Merge branch 'master' into JDK-8336043
>  - Appease jcheck.
>  - JDK-8336043: Add quality of implementation discussion to Object.{equals, toString, hashCode}

src/java.base/share/classes/java/lang/Object.java line 211:

> 209:      * @see     #hashCode()
> 210:      * @see     java.util.HashMap
> 211:      * @see     ##objectOverrides Guidance for overriding {@code Object} methods

Is this rendered as code font? I think only `<`-starting text is not rendered as code font.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20128#discussion_r1787103424


More information about the core-libs-dev mailing list