RFR: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN [v2]

[Eirik Bjørsnøs]

On Mon, 7 Oct 2024 11:35:00 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Mark this resource hungry test manual
>>  - For the benefit of the interpreter, extract loop predicate into a local variable
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1772:
> 
>> 1770:             int pos = 0;
>> 1771:             manifestNum = 0;
>> 1772:             while (pos <= cen.length - CENHDR) {
> 
> The interpreter would probably like something like: 
> 
> int limit = cen.length - CENHDR;
> while (pos <= limit) {

Fixed, look like a good improvement.

> test/jdk/java/util/zip/ZipFile/CenSizeMaximum.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: /* @test
> 
> Yes, this test probably should be either manual or moved to a higher tier.

Added `/manual` for now since I wouldn't know how to move tests between tiers :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21378#discussion_r1790106513
PR Review Comment: https://git.openjdk.org/jdk/pull/21378#discussion_r1790107718