RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v5]

Lance Andersen lancea at openjdk.org
Mon Oct 7 18:09:44 UTC 2024


On Wed, 2 Oct 2024 00:25:00 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> This PR support a -k, --keep options like tar that allows jar to avoid override existing files.
>
> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More review comments

Overall,  this looks ok

We will also need an RN which would be good to have available when the CSR is finalized to review

src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 322:

> 320: \  -k, --keep-old-files       Do not overwrite existing files.\n\
> 321: \                             If a file with the same name exists in the target\n\
> 322: \                             directory, skip the extraction of that file.\n\

This is OK, but I would probably just  the if the file exists, it will not be overwritten

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21141#pullrequestreview-2352617048
PR Review Comment: https://git.openjdk.org/jdk/pull/21141#discussion_r1790662939


More information about the core-libs-dev mailing list