RFR: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils [v4]

Chen Liang liach at openjdk.org
Tue Oct 8 01:16:59 UTC 2024


On Tue, 8 Oct 2024 01:05:14 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename get64 -> get64S
>
> src/java.base/share/classes/java/util/zip/ZipUtils.java line 173:
> 
>> 171:      * The bytes are assumed to be in Intel (little-endian) byte order.
>> 172:      */
>> 173:     public static final int get16(byte[] b, int off) {
> 
> Can JIT automatically perform MergeStore here? If JIT can automatically perform MergeStore without using Unsafe, many scenarios will benefit.

Unfortunately we only have merge store for writing to arrays; no merge load when we are reading from arrays.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21377#discussion_r1791054849


More information about the core-libs-dev mailing list