RFR: 8341566: Adding factory for non-synchronized CharSequence Reader [v4]

Markus KARG duke at openjdk.org
Tue Oct 8 12:02:00 UTC 2024


On Tue, 8 Oct 2024 11:38:12 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - renamed source to cs; cs is final; close sets boolean; no adouble reference to source
>>  - Fixed Typo: 'resect' -> 'respect'
>>  - Improved wording: 'The returned reader supports the {@link #mark mark()} operation'
>>  - Improved wording: 'Returns a {@code Reader} that reads characters from a {@code CharSequence}, starting at the first character in the sequence'
>>  - test for generic read(char, int, int) case
>>  - Remove useless test
>
> src/java.base/share/classes/java/io/Reader.java line 155:
> 
>> 153:      * have no effect.
>> 154:      *
>> 155:      * <p> After the reader has been closed, the {@code read()},
> 
> The API docs in 5cbc0450 looks okay. One minor comment is that "After the reader has been closed ..." doesn't need to be a new paragraph as it's part of the lifecycle topic in the previous paragraph.

IIUC I shall just remove the `<p>` but keep the text `After the reader...`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1791741264


More information about the core-libs-dev mailing list