RFR: 8341566: Adding factory for non-synchronized CharSequence Reader [v3]

Chen Liang liach at openjdk.org
Tue Oct 8 12:34:59 UTC 2024


On Tue, 8 Oct 2024 06:48:59 GMT, Markus KARG <duke at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/Reader.java line 154:
>> 
>>> 152:      * have no effect.
>>> 153:      *
>>> 154:      * <p> After the reader has been closed, the {@code read()},
>> 
>> This paragraph is okay but the Reader methods should really specify this (doing so after 25+ years of being unspecified would require being confident wouldn't invalidate any existing Readers).
>
> IIUC then there is nothing to change in this PR?

Yep, I believe we will specify the closed behavior of methods on reader in a separate RFE. Not to worry for this patch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1791790362


More information about the core-libs-dev mailing list