RFR: 8338544: Dedicated Array class descriptor implementation [v3]

Mandy Chung mchung at openjdk.org
Tue Oct 8 19:44:58 UTC 2024


On Tue, 8 Oct 2024 19:32:34 GMT, Chen Liang <liach at openjdk.org> wrote:

>> @cl4es discovered that Stack Map generation in ClassFile API uses `componentType` and `arrayType` for `aaload` `aastore` instructions, which are currently quite slow. We can split out array class descriptors from class or interfaces to support faster `arrayType` and `componentType` operations.
>> 
>> Tentative, as I currently have no way to measure the actual impact of this patch on the startup performance; however, this made the `ClassDesc` implementations much cleaner.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   mlchung suggestions: elementType, improve utility methods

src/java.base/share/classes/jdk/internal/constant/ConstantUtils.java line 313:

> 311:             throw new IllegalArgumentException("rank " + rank + " is not a positive value");
> 312:         }
> 313:     }

Suggest to inline the rank argument check in the caller method which makes the check explicit to the reader.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20665#discussion_r1792414077


More information about the core-libs-dev mailing list