RFR: 8341273: JVMTI is not properly hiding some continuation related methods

[Serguei Spitsyn]

On Mon, 7 Oct 2024 22:41:06 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition frames hiding mechanism.
>> Please, see a fix description in the first comment.
>> 
>> Testing:
>>  - Verified with new test `vthread/CheckHiddenFrames`
>>  - Mach5 tiers 1-6 are passed
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/CheckHiddenFrames/CheckHiddenFrames.java line 25:
> 
>> 23: 
>> 24: /*
>> 25:  * @test id=virtual
> 
> Having 'id=virtual' not needed and might confuse people. They expect to have other test variations for platform.

Good suggestion, thanks. Removed.

> test/hotspot/jtreg/serviceability/jvmti/vthread/CheckHiddenFrames/CheckHiddenFrames.java line 32:
> 
>> 30: 
>> 31: public class CheckHiddenFrames {
>> 32:     private static final String AGENT_LIB = "CheckHiddenFrames";
> 
> It is not used?

Thanks, removed. I saw it but forgot to remove.

> test/hotspot/jtreg/serviceability/jvmti/vthread/CheckHiddenFrames/CheckHiddenFrames.java line 43:
> 
>> 41: 
>> 42:     public static void main(String[] args) throws Exception {
>> 43:         Thread thread = Thread.ofVirtual().unstarted(CheckHiddenFrames::test);
> 
> You can use 
> startVirtualThread
> to save one line.

Good suggestion, thanks.
Changed to use startVirtualThread.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1793023718
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1793024733
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1793023025