RFR: 8339205: Optimize StackMapGenerator [v4]

[Chen Liang]

On Sat, 5 Oct 2024 15:42:08 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> Reduce code size by combining calls and defining local variables
>
> Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
> 
>  - Merge branch 'master' into optim_stack_map_gen_202408
>  - Merge branch 'master' into optim_stack_map_gen_202408
>  - reduce codeSize
>  - reduce codeSize
>  - decStack & stackUnderflow
>  - fix merge error
>  - Merge branch 'master' into optim_stack_map_gen_202408
>  - Merge remote-tracking branch 'upstream/master' into optim_stack_map_gen_202408
>    
>    # Conflicts:
>    #	src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>  - Merge remote-tracking branch 'upstream/master' into optim_stack_map_gen_202408
>    
>    # Conflicts:
>    #	src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
>  - fix merge error
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/1c3e56c3...59102d50

Changes requested by liach (Reviewer).

src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java line 555:

> 553:                  currentFrame.dup2_x1();
> 554:             case DUP2_X2 ->
> 555:                  currentFrame.dup2_x2();

These few lines of code have 5-space indent; use 4 spaces.

src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java line 1031:

> 1029:             int stackSize = this.stackSize;
> 1030:             if (stackSize < 4) throw stackUnderflow();
> 1031:             checkStack(stackSize + 4);

Suggestion:

            checkStack(stackSize + 2);

-------------

PR Review: https://git.openjdk.org/jdk/pull/20756#pullrequestreview-2357745336
PR Review Comment: https://git.openjdk.org/jdk/pull/20756#discussion_r1793886571
PR Review Comment: https://git.openjdk.org/jdk/pull/20756#discussion_r1793881046