RFR: 8341566: Add Reader.of(CharSequence) [v7]
Roger Riggs
rriggs at openjdk.org
Wed Oct 9 19:18:26 UTC 2024
On Wed, 9 Oct 2024 18:37:53 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in https://openjdk.org/jtreg/tag-spec.html#ORDER
>
> src/java.base/share/classes/java/io/Reader.java line 145:
>
>> 143: /**
>> 144: * Returns a {@code Reader} that reads characters from a
>> 145: * {@code CharSequence}, starting at the first character in the sequence.
>
> The first line comment should be brief and avoid unnecessary details. It is used in method summaries and should stand alone.
> The phrase ", starting at the first character in the sequence" should be moved to a separate sentence.
I see Alan and I have different views on the inclusion of the details.
With only a single CharSequence argument, I can't see any ambiguity about the starting position.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1794090678
More information about the core-libs-dev
mailing list