RFR: 8341566: Add Reader.of(CharSequence) [v7]
Chen Liang
liach at openjdk.org
Wed Oct 9 19:21:24 UTC 2024
On Wed, 9 Oct 2024 18:40:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - assertThrows instead of expectedExceptions
>> - ordered jtreg tags according recommendation in https://openjdk.org/jtreg/tag-spec.html#ORDER
>
> src/java.base/share/classes/java/io/Reader.java line 161:
>
>> 159: * {@code transferTo()} methods all throw {@code IOException}.
>> 160: *
>> 161: * <p> The returned reader supports the {@link #mark mark()} operation.
>
> It may be useful to mention and link to the #reset method as well.
I think `mark()`'s specification implies that if mark is supported, then `reset()` can be called. We can make that explicit on `mark()`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1794110239
More information about the core-libs-dev
mailing list