RFR: 8340801: Disable ubsan checks in some awt/2d coding [v4]
Julian Waters
jwaters at openjdk.org
Thu Oct 10 08:26:12 UTC 2024
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan enabled binaries.
>> However at most of these locations the coding should work (at least on our supported platform set) so the warnings can be disabled at least for now.
>>
>> The change adds a macro ATTRIBUTE_NO_UBSAN similar to what we already use in Hotspot coding.
>
> Matthias Baesken has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into JDK-8340801
> - move ub.h to a better location
> - remove ubsan changes from jni_md.h
> - JDK-8340801
I do wonder why the header both here and inside HotSpot is named ub.h instead of ubsan.h. Latter sounds better to me, but it doesn't really matter much
-------------
PR Review: https://git.openjdk.org/jdk/pull/21184#pullrequestreview-2359482852
More information about the core-libs-dev
mailing list