RFR: 8341470: BigDecimal.stripTrailingZeros() optimization [v33]

[Raffaello Giulietti]

On Fri, 11 Oct 2024 19:25:51 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> Sorry, this is not a good question, disregard.
>
>> As I asked above, what's the property that should hold? 5^`maxPowsOf5` <= `intVal` < 5^(`maxPowsOf5` + 1)?
> 
> Yes, as `floor(log5(intVal)) == max{integer n : 5^n <= intVal}`.

This doesn't say much about `maxPowsOf5`, though. You are not using `intVal` but 2^`bitLength` > `intVal` in the computation of `maxPowsOf5`.
So maybe the property you are looking for is
`maxPowsOf5` - 1 <= log5(intVal) < `maxPowsOf5` || `maxPowsOf5` <= log5(intVal) < `maxPowsOf5` + 1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21323#discussion_r1797357351