RFR: 8341470: BigDecimal.stripTrailingZeros() optimization [v42]

j3graham duke at openjdk.org
Sun Oct 13 14:43:16 UTC 2024


On Sat, 12 Oct 2024 17:37:25 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor change

src/java.base/share/classes/java/math/BigDecimal.java line 5234:

> 5232:      */
> 5233:     private static BigInteger fiveToTwoToThe(int n) {
> 5234:         int i = Math.min(n, FIVE_TO_2_TO.length - 1);

BigInteger has “getRadixConversionCache” which could be made accessible and used here - perhaps with a better name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21323#discussion_r1798379273


More information about the core-libs-dev mailing list