RFR: 8341584: Test java/foreign/TestUpcallStress.java intermittent timeout with -Xcomp

Jaikiran Pai jpai at openjdk.org
Tue Oct 15 06:39:08 UTC 2024


On Tue, 15 Oct 2024 01:25:56 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Test `java/foreign/TestUpcallStress.java` intermittent timeout with -Xcomp, and this test use a very precise race, thus `-Xcomp` probably will never trigger the problematic use-case. So this test not suitable for -Xcomp mode.I add `@requires vm.compMode != "Xcomp"` to exclude from Xcomp testing and remove this test from `ProblemList-Xcomp.txt`.
> Trivial fix, test-fix only, no risk.

The change looks OK to me. Please wait for Jorn @JornVernee to take a look, before integrating.

@sendaoYan  I forgot to ask, were you able to verify that this change continues to prevent the failures that were noticed previously?

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21512#pullrequestreview-2368296431
PR Comment: https://git.openjdk.org/jdk/pull/21512#issuecomment-2413014555


More information about the core-libs-dev mailing list