RFR: 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust [v3]

Ramkumar Sunderbabu rsunderbabu at openjdk.org
Tue Oct 15 16:13:13 UTC 2024


On Tue, 15 Oct 2024 15:29:54 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> AFAIU, the original intention of the test is to check if Instant.now and Instant.now(Clock.systemUTC()) returns almost same time since the underlying clock is same.
>> Given that premise,
>> suggestion 1: it does the job but doesn't show the intention in a better way.
>> suggestion 2: it is not same as what the test wanted to check.
>> If you are fine, I would like to retain the logic I have in my latest commit.
>
> I am fine with it.

Thanks @dfuch

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21413#discussion_r1801511176


More information about the core-libs-dev mailing list