RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v24]

Jatin Bhateja jbhateja at openjdk.org
Wed Oct 16 17:29:05 UTC 2024


On Tue, 15 Oct 2024 10:17:40 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update adlc changes.
>
> src/hotspot/share/opto/vectornode.hpp line 161:
> 
>> 159:   // Needed for proper cloning.
>> 160:   virtual uint size_of() const { return sizeof(*this); }
>> 161:   bool is_unsigned() { return _is_unsigned; }
> 
> Can you put this in the `print_spec`, so the IR dump shows if it is unsigned?

I think you meant Node::dump_spec. Its a good suggestions, addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1803527017


More information about the core-libs-dev mailing list