RFR: 8340553: ZipEntry field validation does not take into account the size of a CEN header
Lance Andersen
lancea at openjdk.org
Wed Oct 16 17:45:52 UTC 2024
Please review the changes for [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which addresses that
- ZipEntry(String)
- ZipEntry::setComment
- ZipEntry::setExtra
currently validate that the max possiible field size is 0xFFFF(65535) instead of 0xFFD1(65489) not taking into account the size of the CEN header which is 46 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12
The CSR has been approved.
Mach5 tiers1-3 run clean as do the relevant JCK tests
-------------
Commit messages:
- initial ZipEntry Max field size changes
Changes: https://git.openjdk.org/jdk/pull/21544/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21544&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8340553
Stats: 246 lines in 4 files changed: 201 ins; 21 del; 24 mod
Patch: https://git.openjdk.org/jdk/pull/21544.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21544/head:pull/21544
PR: https://git.openjdk.org/jdk/pull/21544
More information about the core-libs-dev
mailing list