RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v6]

[Ioi Lam]

On Wed, 16 Oct 2024 05:13:13 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 31 commits:
>> 
>>  - @DanHeidinga comments -- added comments and asserts related to ClassLoaderData used by archived hidden classes
>>  - Merge branch 'jep-483-step-06-8311071-avoid-soft-refs-in-java-lang-invoke' into jep-483-step-07-8293336-store-lambda-forms-in-cds-archive
>>  - @DanHeidinga comments -- added ConcurrentHashMap::runtimeSetup() to init NCPU to runtime value; also use the same runtimeSetup() pattern to call registerNatives() for Class.java and Unsafe.java
>>  - Merge branch 'jep-483-step-06-8311071-avoid-soft-refs-in-java-lang-invoke' into jep-483-step-07-8293336-store-lambda-forms-in-cds-archive
>>  - Fixed JDK-8341988: jstack launched with AOT cache created with -XX:+AOTClassLinking crashes
>>  - 8341600: [premain] Automatic aot-init of classes used by java.lang.invoke
>>  - @adinn comments
>>  - improve checks for not changing <clinit> order for aot linking of lambda; added comprehensive test cases: AOTLinkedLambdasApp::testClinitOrder()
>>  - Clean up of aotClassInitializer and cdsHeaVerifier; added lambda test cases for <clinit> order of app classes
>>  - Merge branch 'jep-483-step-06-8311071-avoid-soft-refs-in-java-lang-invoke' into jep-483-step-07-8293336-store-lambda-forms-in-cds-archive
>>  - ... and 21 more: https://git.openjdk.org/jdk/compare/11391c39...a6ad908f
>
> src/hotspot/share/cds/heapShared.cpp line 447:
> 
>> 445: 
>> 446: bool HeapShared::is_string_concat_klass(InstanceKlass* ik) {
>> 447:   return ik->is_hidden() && ik->name()->starts_with("java/lang/String$$StringConcat");
> 
> Can you add a comment in `StringConcatFactory`'s place where this name is defined, so others who change the generated class name will remember to update references here?

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1804080661