Would it make sense to add a new constructor to java.io.SequenceInputStream?

[David Alayachew]

Well, my personal use case is to Frankenstein my own InputStream out of
several different things for libraries that only take InputStream. For
example, what if I need to prepend or postpend with a newline? I am doing
that now, which is actually what prompted me to ask this.

On Thu, Oct 17, 2024, 1:33 AM Jaikiran Pai <jai.forums2013 at gmail.com> wrote:

> It was suggested in that PR that the discussion be brought to this mailing
> list to gather any inputs and interest in the change. Except for your
> current mail, there hasn't been any other discussion here in the mailing
> list about it.
>
> In the PR itself I haven't seen any objections to this change, but it
> isn't clear what motivated the new constructor. Does it fall into the
> good-to-have category? How frequently the SequenceInputStream gets used and
> whether this new constructor would help such usages wasn't explained
> either.
>
> If you do pick this up, I think it would be useful to find out what kind
> of usage the SequenceInputStream class sees in libraries and whether this
> new constructor is going to be helpful for such usages.
>
> -Jaikiran
> On 17/10/24 10:36 am, David Alayachew wrote:
>
> Hello Jaikiran,
>
> Thanks for the response. This is exactly what I was looking for.
>
> Does this mean that this is up for grabs? There was a comment near the
> bottom about more evaluations, but that was also in 2023.
>
> If all I need to do is continue the work that the other person was doing,
> I am more than happy to.
>
> Looks like in the pr attempted but closed, all Aleksey Shipilëv wanted was
> for the developer to activate the test suite, so that they could see that
> the tests passed. It sounds like all I need to do is do that and then we
> should be good for review?
>
> On Thu, Oct 17, 2024, 12:54 AM Jaikiran Pai <jai.forums2013 at gmail.com>
> wrote:
>
>> Hello David,
>>
>> There's an enhancement request for this here
>> https://bugs.openjdk.org/browse/JDK-8305947
>>
>> -Jaikiran
>>
>> On 17/10/24 9:17 am, David Alayachew wrote:
>> > Hello Core Libs Dev Team,
>> >
>> > Currently, java.io.SequenceInputStream only has 2 constructors -- one
>> > that takes in 2 instances of InputStream, and another that takes in an
>> > Enumeration of type InputStream.
>> >
>> > Would it make sense to add a third constructor that takes in multiple
>> > instances of InputStream? I don't know if a list, an array, varargs,
>> > etc makes more sense. But I would think a 3rd constructor would
>> > improve this API.
>> >
>> > Thank you for your time and help.
>> > David Alayachew
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20241017/cded00d2/attachment.htm>