RFR: 8340553: ZipEntry field validation does not take into account the size of a CEN header [v2]

Lance Andersen lancea at openjdk.org
Thu Oct 17 13:55:49 UTC 2024


On Thu, 17 Oct 2024 11:41:05 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add back missing putNextEntry call
>
> test/jdk/java/util/zip/ZipOutputStream/ZipOutputStreamMaxCenHdrTest.java line 73:
> 
>> 71:     static final String ENTRY_COMMENT = "A Comment";
>> 72:     // Max length minus the size of the ENTRY_NAME or ENTRY_COMMENT
>> 73:     static final int MAX_FIElD_LEN_MINUS_ENTRY_NAME =
> 
> The "l" in "FIElD" seems lowercase?

Thanks fixed and easy to miss :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21544#discussion_r1804830326


More information about the core-libs-dev mailing list