RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Oct 18 16:21:11 UTC 2024


On Fri, 18 Oct 2024 02:25:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused classes
>
> src/hotspot/share/classfile/classFileParser.cpp line 4098:
> 
>> 4096:       }
>> 4097:     }
>> 4098: 
> 
> This code should not be removed. The spec for this code should now be:
> 
>   // If the loader is not the boot loader then throw an exception if its
>   // superclass is in package jdk.internal.reflect 
> 
> All we need do is remove the check:
> 
> && !java_lang_ClassLoader::is_reflection_class_loader

Oh that's a good find.  Maybe we should write a test for this, if as I assume there isn't one already.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21571#discussion_r1806742713


More information about the core-libs-dev mailing list