RFR: 8340553: ZipEntry field validation does not take into account the size of a CEN header [v7]

Lance Andersen lancea at openjdk.org
Fri Oct 18 20:06:14 UTC 2024


> Please review the changes for [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which addresses that
> 
> - ZipEntry(String)
> - ZipEntry::setComment
> - ZipEntry::setExtra
> 
> currently validate that the max possiible field size is 0xFFFF(65535) instead of  0xFFD1(65489) not taking into account the size of the CEN header which is 46 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12 
> 
> The CSR has been approved.
> Mach5 tiers1-3 run clean as do the relevant JCK tests

Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:

  change field -> fields

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21544/files
  - new: https://git.openjdk.org/jdk/pull/21544/files/76b7d1ad..028af01c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21544&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21544&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/21544.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21544/head:pull/21544

PR: https://git.openjdk.org/jdk/pull/21544


More information about the core-libs-dev mailing list