RFR: 8341260: Add Float16 to jdk.incubator.vector [v2]

Jatin Bhateja jbhateja at openjdk.org
Mon Oct 21 06:30:24 UTC 2024


On Sun, 20 Oct 2024 18:59:36 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Port of Float16 from java.lang in the lworld+fp16 branch to jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove comments for intrinsics per review feedback.

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line 968:

> 966:         // for preserving the correct final value. The conversion
> 967:         // Float16 -> double preserves the exact numerical value. The
> 968:         // of the double -> Float16 conversion also benefits from the

Suggestion:

        // Float16 -> double preserves the exact numerical value. The
        // conversion of the double -> Float16 also benefits from the

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21574#discussion_r1808171758


More information about the core-libs-dev mailing list