RFR: 8327624: Remove VM implementation that bypass verification for core reflection [v2]

[David Holmes]

On Sat, 19 Oct 2024 06:33:01 GMT, ExE Boss <duke at openjdk.org> wrote:

>> `test/hotspot/jtreg/runtime/AccessCheckSuper.java` is one test that fails the super class access check.  @lfoltan may know whether there are more tests besides this one.
>
> This code was necessary back when this was the `sun.reflect` package and it was not able to be encapsulated (before modules) to prevent untrusted class loaders from leaking the `MagicAccessorImpl` class hierarchy.

Okay ... so such subclass was and remains illegal and is now detected slightly later. That suggests to me this special case was in the wrong place and should have been inside `Reflection::verify_class_access`.

Anyway thanks for clarifying full removal is in fact what we want.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21571#discussion_r1808498120