RFR: 8341402: BigDecimal's square root optimization [v5]

fabioromano1 duke at openjdk.org
Mon Oct 21 11:35:02 UTC 2024


> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed up `BigDecimal.sqrt()` implementation. Here is how I made it.
> 
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
> 
> x = y * 10 ^ exp
> sqrt(x) = sqrt(y) * 10^(exp / 2) if exp is even
> sqrt(x) = sqrt(y*10) * 10^((exp-1)/2) is exp is odd
> 
> Then use BigInteger.sqrt() on the reduced value to compute the numerical digits of the desired result.
> 
> Finally, scale back to the desired exponent range and perform any adjustment to get the preferred scale in the representation.

fabioromano1 has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'openjdk:master' into patchBigDecimalSqrt
 - Avoid check for null value of this.intVal
 - Demand overflow checks to checkScale()
 - Removed stripZerosToEvenScale to simplify the code
 - Merge branch 'openjdk:master' into patchBigDecimalSqrt
 - Change BigDecimal.sqrt() implementation

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21301/files
  - new: https://git.openjdk.org/jdk/pull/21301/files/acbe9927..e7a225be

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21301&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21301&range=03-04

  Stats: 64282 lines in 1266 files changed: 53046 ins; 5940 del; 5296 mod
  Patch: https://git.openjdk.org/jdk/pull/21301.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21301/head:pull/21301

PR: https://git.openjdk.org/jdk/pull/21301


More information about the core-libs-dev mailing list