RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v3]

[David M. Lloyd]

> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a `Runnable`, which is consumed by a `Consumer<Runnable>` (instantiated within a loop) which runs the task inside if a `try`/`catch`. We can eliminate a number of lambdas and method references, plus some allocation pressure, in this code by simplifying it so that the `switch` is itself run directly within the `try`/`catch`.

David M. Lloyd has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Make sure that we record every error instead of stopping at the first error in a particular CPE
 - 8341028: Do not use lambdas or method refs for verifyConstantPool
   
   Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a `Runnable`, which is consumed by a `Consumer<Runnable>` (instantiated within a loop) which runs the task inside if a `try`/`catch`. We can eliminate a number of lambdas and method references, plus some allocation pressure, in this code by simplifying it so that the `switch` is itself run directly within the `try`/`catch`.

-------------

Changes: https://git.openjdk.org/jdk/pull/21209/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21209&range=02
  Stats: 80 lines in 1 file changed: 38 ins; 10 del; 32 mod
  Patch: https://git.openjdk.org/jdk/pull/21209.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21209/head:pull/21209

PR: https://git.openjdk.org/jdk/pull/21209