Integrated: 8340553: ZipEntry field validation does not take into account the size of a CEN header

Lance Andersen lancea at openjdk.org
Mon Oct 21 15:37:28 UTC 2024


On Wed, 16 Oct 2024 17:40:36 GMT, Lance Andersen <lancea at openjdk.org> wrote:

> Please review the changes for [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which addresses that
> 
> - ZipEntry(String)
> - ZipEntry::setComment
> - ZipEntry::setExtra
> 
> currently validate that the max possiible field size is 0xFFFF(65535) instead of  0xFFD1(65489) not taking into account the size of the CEN header which is 46 bytes per the PKWare APP.NOTE 4.4.10, 4.4.11, & 4.4.12 
> 
> The CSR has been approved.
> Mach5 tiers1-3 run clean as do the relevant JCK tests

This pull request has now been integrated.

Changeset: 54a744b0
Author:    Lance Andersen <lancea at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/54a744b0235ab2987f2e9c78fb5326b15233d176
Stats:     423 lines in 4 files changed: 228 ins; 187 del; 8 mod

8340553: ZipEntry field validation does not take into account the size of a CEN header

Reviewed-by: jpai, redestad, eirbjo

-------------

PR: https://git.openjdk.org/jdk/pull/21544


More information about the core-libs-dev mailing list