RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v4]

[Ioi Lam]

On Mon, 14 Oct 2024 15:54:15 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed JDK-8341988: jstack launched with AOT cache created with -XX:+AOTClassLinking crashes
>
> src/hotspot/share/cds/archiveUtils.cpp line 377:
> 
>> 375:   if (SystemDictionaryShared::is_excluded_class(src_ik)) {
>> 376:     return false;
>> 377:   }
> 
> Do we want an assert here that `ArchiveBuilder::current()->get_buffered_addr(src_ik)->has_aot_initialized_mirror() == false`?

These classes are not buffered so `ArchiveBuilder::current()->get_buffered_addr(src_ik)` won't work. I added this assert instead.


  if (SystemDictionaryShared::is_excluded_class(src_ik)) {
    assert(!ArchiveBuilder::current()->has_been_buffered(src_ik), "sanity");
    return false;
  }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1810019800