RFR: 8319343: Improve CDS module graph support for --add-modules option [v2]

Alan Bateman alanb at openjdk.org
Tue Oct 22 12:45:21 UTC 2024


On Mon, 21 Oct 2024 16:29:40 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Good point as ALL-SYSTEM and ALL-MODULE-PATH are allowed in the value. I assume you don't need to special case the single value case as this is dump time so not performance critical.
>
> I've removed the `if` check at the beginning of the method.

Thanks, I'll get back to you on but I want see how this will behave with ALL-MODULE-PATH as that will sometimes appear in Maven environments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21553#discussion_r1810653443


More information about the core-libs-dev mailing list