RFR: 8293336: AOT-linking of invokedynamic for lambda expression and string concat [v10]

Ioi Lam iklam at openjdk.org
Tue Oct 22 15:35:43 UTC 2024


On Tue, 22 Oct 2024 07:06:11 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> I changed the code to `assert(is_pending_aot_linked_class(k), "sanity")`. Since iterator.hpp is widely used, I avoid including aotLinkedClassBulkLoader.hpp in this header, and route the call through iterator.cpp.
>
> My proposal was to use it in this file (iterator.inline.hpp) and not iterator.hpp. I see no need to route this through the .cpp file.

iterator.inline.hpp is included by many cpp file (580 out of 1409 .o files in hotspot), so I don't want to add aotLinkedClassBulkLoader.hpp to it.


scanning    580 iterator.inline.hpp
   2 found    580 oop.inline.hpp
   3 found    580 zIterator.inline.hpp
   4 found    580 zBarrierSet.inline.hpp
   5 found     60 g1OopClosures.inline.hpp
   6 found      7 g1FullGCOopClosures.inline.hpp
   7 found      5 psPromotionManager.inline.hpp

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1810959378


More information about the core-libs-dev mailing list