RFR: 8341975: Unable to set encoding for IO.println, IO.print and IO.readln [v4]

Naoto Sato naoto at openjdk.org
Tue Oct 22 16:56:48 UTC 2024


On Tue, 22 Oct 2024 16:26:29 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/System.java line 150:
>> 
>>> 148:      * specified by the host environment or user. The encoding used
>>> 149:      * in the conversion from characters to bytes is equivalent to
>>> 150:      * <a href="#stdout.encoding">stdout.encoding</a>.
>> 
>> Suggestion:
>> 
>>      * {@systemProperty stdout.encoding}.
>> 
>> 
>> This defines the anchor with the same id, and also makes this property available for javadoc index search. Example includes the system property at https://download.java.net/java/early_access/jdk24/docs/api/java.base/java/lang/ClassLoader.html#java.system.class.loader
>
> Hello Chen, the `{@systemProperty}` tag is expected to be used where the system property is being defined (the "Where should the tag be used?" section in https://mail.openjdk.org/pipermail/core-libs-dev/2018-November/056653.html). 
> On this line, it's merely being referenced and the actual definition of this property is in the documentation of System.getProperties() method and there it correctly already uses a `{@systemProperty}` tag for this property https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/System.java#L790

@jaikiran is correct. `stdout.encoding` has already been searchable. That said, using HTML anchor tag can be replaced with link tag. Also this modification needs to be done for `stderr.encoding` too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21569#discussion_r1811080169


More information about the core-libs-dev mailing list