RFR: 8342807: Update links in java.base to use https://
Justin Lu
jlu at openjdk.org
Tue Oct 22 17:58:06 UTC 2024
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this cleanup PR which updates a total of 12 links to external documentation or references in `java.base` to use https instead of plain text http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>
> This is a documentaton-only cleanup. No tests are added or updated. `noreg-cleanup` added in the JBS. All updated links have been verified to resolve and to show the expected content.
>
> There are two files here with non-Oracle copyright headers, not quite sure how to update those? (`java_md_aix.h` and `xss-common-qsort.h`).
>
> Changes beyond the obvious are as follows:
>
> `linux/native/libsimdsort/xss-common-qsort.h`:
> The current link uses a non-default port number. Changed to using the default port number. Reported upstream as intel/x86-simd-sort#170
>
> `share/man/keytool.1`:
> www.oracle.com redirects this from `/technetwork/java/javase/javasecarootcertsprogram-1876540.html` to `/java/technologies/javase/carootcertsprogram.html`. Using the new URL here. Should this be updated in Oracle-internal sources as well?
>
> `unix/classes/sun/net/PortConfig.java`
> The current link no longer resolves. As a replacement, I suggest https://www.ibm.com/support/pages/node/886227 which answers a support question regarding ephemeral ports.
>
> `unix/native/libjava/*`,
> Links redirect from "www.opengroup.org" to "pubs.opengroup.org". Using this new host in the URLs
>
> `unix/native/libjava/ProcessImpl_md.c`
> A link to pasc.org now requires authentication. I changed this to be a Wayback link. Alternantives would be to delete this link, or to track down a revised version of the spec the linked Interpretation Request refers to.
Most new links look fine to me/resolve correctly minus the comments. I believe we should not modify the non-Oracle copyright headers at all.
src/java.base/unix/native/libjava/ProcessImpl_md.c line 109:
> 107: * the jspawnhelper, then in the jspawnhelper we do the pre-exec work and exec a
> 108: * second time, this time the target binary (similar to the "exec-twice-technique"
> 109: * described in 'https://mail.openjdk.org/pipermail/core-libs-dev/2018-September/055333.html).
Unintentional `'` was added.
src/java.base/unix/native/libjava/ProcessImpl_md.c line 204:
> 202: * References:
> 203: * https://pubs.opengroup.org/onlinepubs/7908799/xsh/exec.html
> 204: * https://web.archive.org/web/20090106162458/http://www.pasc.org/interps/unofficial/db/p1003.1/pasc-1003.1-132.html
The new Wayback link does not resolve for me.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21633#pullrequestreview-2385886437
PR Review Comment: https://git.openjdk.org/jdk/pull/21633#discussion_r1811137958
PR Review Comment: https://git.openjdk.org/jdk/pull/21633#discussion_r1811151881
More information about the core-libs-dev
mailing list