RFR: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443 [v2]

[Alexander Matveev]

On Tue, 22 Oct 2024 19:35:55 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443 [v2]
>
> test/jdk/tools/jpackage/macosx/base/SigningCheck.java line 104:
> 
>> 102:         } catch (IOException | InterruptedException ex) {
>> 103:             throw new RuntimeException(ex);
>> 104:         }
> 
> Can be reduced to:
> 
> 
> public static void isXcodeDevToolsInstalled() {
>   if (Executor.of("/usr/bin/xcrun", "--help").execute().getExitCode() != 0) {
>     TKit.throwSkippedException("Missing Xcode with command line developer tools");
>   }
> }
> 
> 
> Also will add a log record to help evaluate potential test failure.

Fixed, but I am using `executeWithoutExitCodeCheck()` instead of  `execute()`, `execute()` throws exception if command returns non-zero value.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21628#discussion_r1811505327