RFR: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443 [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Tue Oct 22 22:38:06 UTC 2024
On Tue, 22 Oct 2024 22:17:56 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> - Removed hard check for "Xcode with command line developer tools" when `--mac-sign` is specified and instead we will show information message if `codesign` fails for any reason that possible root cause of failure is missing Xcode with command line developer tools.
>> - Reason for this is that `codesign` works fine on recent macOS versions and it looks like dependency on Xcode with command line developer tools is no longer required. Unfortunately it is unknown which macOS versions are require Xcode with command line developer tools in order to `codesign` work, so this check will be done as soft check.
>> - SigningOptionsTest which requires "Xcode with command line developer tools" on some older macOS versions was modified to skip certain tests which might fail if Xcode is not installed.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>
> 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443 [v2]
Marked as reviewed by asemenyuk (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21628#pullrequestreview-2386518121
More information about the core-libs-dev
mailing list