Withdrawn: 8338931: ZipEntry.flag could be made internal to ZipOutputStream
duke
duke at openjdk.org
Wed Oct 23 15:43:22 UTC 2024
On Sat, 24 Aug 2024 10:49:56 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this refactoring PR which moves the `ZipEntry.flag` field back to `ZipOutputStream.XEntry`.
>
> Moving this field will save four bytes from the `ZipEntry` object size and also saves an unneccessary read in `ZipFile.getZipEntry`.
>
> Testing:
>
> This PR is a refactoring of existing code and does not update any tests. I added the label `noreg-cleanup` to the JBS issue.
>
> The following runs clean:
>
>
> make test TEST="test/jdk/java/util/zip"
> make test TEST="test/jdk/java/util/jar"
>
>
> Performance:
>
> The JMH benchmark `java.util.zip.ZipFileGetEntry.getEntryHit` show a small but consistent improvement (2-3%).
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.org/jdk/pull/20702
More information about the core-libs-dev
mailing list