RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v31]

Emanuel Peter epeter at openjdk.org
Thu Oct 24 06:34:14 UTC 2024


On Thu, 24 Oct 2024 06:28:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Factor out IR tests and Transforms to follow-up PRs.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMath.java line 32:
> 
>> 30:  * @since   24
>> 31:  */
>> 32: public final class VectorMath {
> 
> I think this class could have been split into a separate RFE, together with its tests. I would prefer that next time.

Also: why did we not add these `Long.minUnsigned` etc? I guess that was already discussed?
Because we can easily also use this with the auto-vectorizer or more generally. Saturating and unsigned ops are generally useful I think...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20507#discussion_r1814343654


More information about the core-libs-dev mailing list