RFR: 8341566: Add Reader.of(CharSequence) [v15]

[Markus KARG]

On Wed, 23 Oct 2024 22:15:34 GMT, Kevin Bourrillion <duke at openjdk.org> wrote:

> An issue with the simple name `of` is that we may encounter calls like this:
> 
> `Reader.of("/usr/share/dict/words")`
> 
> ... that may look like they do something different. I can't say whether we should consider this a serious issue or not, though. I don't know if it justifies a big ugly name like `ofCharSequence` or not.

There always will be a small group this misunderstands things and does not read JavaDocs, we can never find "the perfect API" to prevent this completely. The question is if we need to make the API worse in turn and bother all others with ugly lengthy names? I personally think the actual risk here is negligible, and the solution ("RTFM") is rather simple to implement. ;-)

To sum up, IMHO as soon as Chen finished the internal tests, we should close this discussion and merge this PR as-is.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21371#issuecomment-2435379880